fix(utf8): use col_offset for CJK word wrap boundary detection #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Good find. I've got something similar on a branch, but I wasn't happy with the performance impact on |
Add col_offset field to WrapBreak struct for tracking display column. CJK characters have display width 2, so char_offset (character count) differs from col_offset (display column). This fix ensures word wrap boundaries are calculated using display columns.
kskang
force-pushed
the
fix/cjk-col-offset
branch
from
a2870c5 to
02572b3
Compare
Collaborator
|
I think I fixed that with a little bit different approach in #529, it is a little bit more performance aware. Thank you for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CJK characters have display width 2. But the code counted them as width 1 when calculating word wrap boundaries. This caused incorrect wrap positions.
Changes
col_offsetfield toWrapBreakstruct. This field tracks display column position.col_offsetinstead ofchar_offsetin wrap boundary detection.Test
Fixes #255