test(core): add regression tests for CJK line boundary and emoji handling #484
+260
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive regression tests for CJK (Chinese, Japanese, Korean) character handling at line boundaries and emoji handling edge cases, along with a new appendText() method for streaming append scenarios.
- Adds tests ensuring CJK characters wrap correctly at line boundaries without overflow
- Adds tests for complex emoji sequences (ZWJ, flags, skin tones) in textarea keybindings
- Introduces
appendText()method toTextBufferRenderablefor streaming text append use cases
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/zig/tests/text-buffer-drawing_test.zig | Removes cosmetic blank lines and adds Zig-level regression test for streaming append with CJK characters |
| packages/core/src/text-buffer-view.test.ts | Adds comprehensive test suite for CJK character wrapping at line boundaries, including streaming append scenarios |
| packages/core/src/renderables/tests/Textarea.keybinding.test.ts | Adds tests for complex emoji handling (ZWJ sequences, flags, skin tones) in textarea keybindings |
| packages/core/src/renderables/TextBufferRenderable.ts | Adds public appendText() method that wraps textBuffer.append() with proper UI updates |
| packages/core/src/renderables/Text.test.ts | Adds rendering tests for CJK text with wrapping and streaming append scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ling - Add CJK character at line boundary tests (text-buffer-view.test.ts) - Add CJK wrapping and streaming append tests (Text.test.ts) - Add Zig native test for streaming append with CJK (text-buffer-drawing_test.zig) - Add Textarea keybinding tests for ZWJ emoji, flags, skin tones - Add appendText() method to TextBufferRenderable for streaming use case
GreyElaina
force-pushed
the
core-unicode-tests
branch
from
7dacee9 to
885e7af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds regression tests for CJK and emoji handling edge cases.
Tests Added
Additional
appendText()method toTextBufferRenderablefor streaming use case