fix(read): enhance file validation with comprehensive magic byte chec… #9810
+146
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king Improve validation against file signatures from Wikipedia's file signature reference to be more robust: - PNG: Validate full 8-byte signature (89 50 4E 47 0D 0A 1A 0A) - JPEG: Validate 3-byte start marker (FF D8 FF) - GIF: Check for GIF87a or GIF89a (6-byte format) - WebP: Validate RIFF...WEBP structure (12-byte check) - PDF: Validate PDF header (25 50 44 46) Add comprehensive test coverage for invalid GIF and PDF files to ensure the robust validation catches misnamed/corrupted files across all formats.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
This looks useful, but I don't think it's a fix for the underlying issue in #9512. The biggest problem there was that whatever caused an error to be thrown bricked the whole session, rather than what it would usually do - tell opencode "XYZ went wrong", so it can smartly figure out what to do instead (in this case go back and figure out why it had an invalid .jpeg file in the first place) |
Author
|
The session isn't being bricked anymore. For the agent to troubleshoot, prompting it to do so would also work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9512
What does this PR do?
Improve validation against file signatures from Wikipedia's file signature reference to be more robust:
Add comprehensive test coverage for invalid GIF and PDF files to ensure the robust validation catches misnamed/corrupted files across all formats.
How did you verify your code works?
Screen.Recording.2026-01-21.at.15.05.03.mov