-
Notifications
You must be signed in to change notification settings - Fork 7.4k
feat(opencode): add configurable shell resolution with plugin support #9724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JohnDeved
wants to merge
3
commits into
anomalyco:dev
Choose a base branch
from
JohnDeved:feat/configurable-shell-resolution
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+221
−11
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import { expect, test, mock } from "bun:test" | ||
| import { Shell } from "../../src/shell/shell" | ||
| import { Config } from "../../src/config/config" | ||
JohnDeved marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| import { Plugin } from "../../src/plugin" | ||
| import { Instance } from "../../src/project/instance" | ||
| import { tmpdir } from "../fixture/fixture" | ||
| import path from "path" | ||
JohnDeved marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| test("Shell.preferred resolves from config", async () => { | ||
| await using tmp = await tmpdir({ | ||
| config: { | ||
| shell: "/custom/shell", | ||
| }, | ||
| }) | ||
|
|
||
| await Instance.provide({ | ||
| directory: tmp.path, | ||
| fn: async () => { | ||
| const shell = await Shell.preferred() | ||
| expect(shell).toBe("/custom/shell") | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| test("Shell.acceptable resolves from config", async () => { | ||
| await using tmp = await tmpdir({ | ||
| config: { | ||
| shell: "/custom/acceptable/shell", | ||
| }, | ||
| }) | ||
|
|
||
| await Instance.provide({ | ||
| directory: tmp.path, | ||
| fn: async () => { | ||
| const shell = await Shell.acceptable() | ||
| expect(shell).toBe("/custom/acceptable/shell") | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| test("Shell.preferred resolves from plugin", async () => { | ||
| const originalTrigger = Plugin.trigger | ||
| Plugin.trigger = mock(async (name, input, output) => { | ||
| if (name === "shell.resolve") { | ||
| output.shell = "/plugin/resolved/shell" | ||
| } | ||
JohnDeved marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }) | ||
|
|
||
| try { | ||
| await using tmp = await tmpdir() | ||
| await Instance.provide({ | ||
| directory: tmp.path, | ||
| fn: async () => { | ||
| const shell = await Shell.preferred() | ||
| expect(shell).toBe("/plugin/resolved/shell") | ||
| expect(Plugin.trigger).toHaveBeenCalledWith("shell.resolve", expect.anything(), expect.anything()) | ||
| }, | ||
| }) | ||
| } finally { | ||
| Plugin.trigger = originalTrigger | ||
| } | ||
| }) | ||
|
|
||
| test("Shell.preferred falls back to environment/system", async () => { | ||
| const originalEnvShell = process.env.SHELL | ||
| process.env.SHELL = "/env/shell" | ||
|
|
||
| try { | ||
| await using tmp = await tmpdir() | ||
| await Instance.provide({ | ||
| directory: tmp.path, | ||
| fn: async () => { | ||
| const shell = await Shell.preferred() | ||
| expect(shell).toBe("/env/shell") | ||
| }, | ||
| }) | ||
| } finally { | ||
| process.env.SHELL = originalEnvShell | ||
| } | ||
| }) | ||
JohnDeved marked this conversation as resolved.
Show resolved
Hide resolved
JohnDeved marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.