Skip to content

Conversation

basilkhan05
Copy link
Contributor

This pull request is in reference to the - add to dashboard from query page in the issue #24.

This PR allows the user to add the queries to multiple dashboards right from the query show page.

  • When the user adds the query, this is appended to the end of the dashboard page (with position n+1, where n is the number of current queries on the dashboard)
  • When the user removes the query, the query is deleted from the current position
  • The dashboard_query positions are reset after removal of queries for each of the dashboards that were modified

Below is a quick video for an overview of the functionality:

Play Video

Blazer PR | Hide Mastermind if user_class does not exist

Below is the screenshot of the Add to Dashboard modal:
image

- routes and controller to handle adding queries across multiple dashboards
- fix controller method for queries
- Fix route to post for add_to_dashboard
- only destroyed_dashboard_queries are modified
@ACPK
Copy link

ACPK commented May 16, 2019

@basilkhan05 @ankane - I love this and can't wait for it to be in the master branch!

@ankane
Copy link
Owner

ankane commented May 29, 2019

Hey @basilkhan05, thanks for this one as well. Will take a look when I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants