Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(m3-tokens): wrong hue reference #29902

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

simonkovtyk
Copy link

@simonkovtyk simonkovtyk commented Oct 21, 2024

Hi there

Recently, I made some own implementations for my company to support multiple paletts for M3 and I orientated my code at the token generation here.

I found out, that Angular Material is sometimes not using the right tokens for some color roles as described in the offical Figma Template here.

Overview

For a better overview, I provided the differences here in a table.

Light mode

Token Hue (Angular Material) Hue (Material spec)
on-primary-container primary-10 primary-30
on-secondary-container secondary-10 secondary-30
on-tertiary-container tertiary-10 tertiary-30
on-error-container error-10 error-30

Dark mode

Token Hue (Angular Material) Hue (Material spec)
surface-container-highest neutral-24 neutral-22

Thank you for your patience!

Copy link

google-cla bot commented Oct 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@simonkovtyk simonkovtyk marked this pull request as ready for review November 21, 2024 12:26
@simonkovtyk simonkovtyk requested a review from a team as a code owner November 21, 2024 12:26
@simonkovtyk simonkovtyk requested review from crisbeto and wagnermaciel and removed request for a team November 21, 2024 12:26
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants