feat(cdk/menu): not to close on outside click, add output event for outside click of menu, add output event for contextmenu
#29872
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds new input in menu trigger which allows users to disable closing menu on outside clicks fixes angular#29072
this commit exposes an output which emits whenever the user clicks outside open menu fixes angular#29072
this commit exposes an output that emits whenever user triggers `contextmenu` event which contains `clientX` and `clientY` position respectively fixes angular#29072
naaajii
requested review from
crisbeto and
amysorto
and removed request for
a team
naaajii
changed the title
contextmenu
wagnermaciel
added
the
needs: discussion
crisbeto
reviewed
Oct 15, 2024
| readonly outsideClicked: EventEmitter<MouseEvent> = new EventEmitter(); | ||
|
|
||
| /** Emits when the user triggers context menu */ | ||
| readonly triggered: EventEmitter<{x: number; y: number}> = new EventEmitter(); |
There was a problem hiding this comment.
What's the context behind exposing these APIs?
There was a problem hiding this comment.
I forgot to include in PR description but it should close #29072.
There was a problem hiding this comment.
I discussed this with the team and the decision is that we are ok with exposing these APIs. There is still some questions on naming which @andrewseguin has the ability to make the final decision on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(cdk/menu): not to close on outside click
this commit adds new input in menu trigger which allows users to disable closing menu on outside clicks
feat(cdk/menu): add output event for outside click of menu
this commit exposes an output which emits whenever the user clicks outside open menu
feat(cdk/menu): add output event for contextmenu
this commit exposes an output that emits whenever user triggers
contextmenuevent which containsclientXandclientYposition respectively