fix(material/badge): remove the console warning - #29800
Open
naaajii wants to merge 2 commits into
Open
Conversation
removes the console.warn when badge is used with aria hidden `mat-icon` fixes angular#27796
naaajii
requested review from
amysorto and
crisbeto
and removed request for
a team
September 28, 2024 20:46
naaajii
commented
Sep 28, 2024
Contributor
Author
There was a problem hiding this comment.
@wagnermaciel @AleksanderBodurri
continuing from this reply i basically have questions regarding for not interactive elements:
mat-iconalso fall will same principal as quoted from link above?- currently badge with mat-icon produces following markup:
<mat-icon matBadge="7">
<span class="mat-badge">7</span>
</mat-icon>the mat-badge should append a span with the description as the next sibling to the element that has the badge on it.
after span change is the following markup valid?
<mat-icon matBadge="7" matBadgeDescription="this is description">
<span class="mat-badge">7</span>
</mat-icon>
<span class="cdk-visually-hidden">this is description</span>move inline description element to be next sibling where `matBadge` was applied instead of being within the non interactive element and invisible to screen readers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(material/badge): remove the console warning
removes the console.warn when badge is used with aria hidden
mat-iconfixes #27796
fix(material/badge): move inline description element to be next sibling
move inline description element to be next sibling where
matBadgewas applied instead of being within the non interactive element and invisible to screen readers