This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Update closure compiler to latest release. #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkirov
commented
Oct 31, 2019
package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "homepage": "https://github.com/angular/clutz", | |||
| "description": "Clutz is not on npm, and technically not a node package. \n This is needed only for testing Clutz's output against the TypeScript compiler, and to install some development dependencies from npm.", | |||
| "devDependencies": { | |||
| "clang-format": "^1.2.3", | |||
| "clang-format": "^1.2.4", | |||
There was a problem hiding this comment.
Unfortunately, even with this there is a difference between internal and external formatting which causes this to still fail :(
There was a problem hiding this comment.
diff:
@@ -39,9 +39,8 @@
class B {
twoLines: {param1: string|undefined} = {param1: 'param1'};
multipleLines: {param2: string|undefined} = {param2: 'param2'};
- twoParams:
- {param3: string|undefined,
- param4: string|undefined} = {param3: 'param3', param4: 'param4'};
+ twoParams: {param3: string|undefined,
+ param4: string|undefined} = {param3: 'param3', param4: 'param4'};
Maybe @mprobst should take a look.
There was a problem hiding this comment.
I'll need to do a clang-format release. That'll take a while as I need to get hold of a windows computer...
There was a problem hiding this comment.
No rush here, just let me know when done.
There was a problem hiding this comment.
@rkirov there's clang-format 1.3.0 on npm now.
There was a problem hiding this comment.
Great, thanks!
Unfortunately, also your latest change ended up using a "too-fresh" API from guava (?) -
/home/circleci/clutz/src/main/java/com/google/javascript/clutz/DeclarationGenerator.java:1327: error: cannot find symbol
.splitToStream(namespace)
So I still can't unbreak the build
Also upgrade clang-format.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.