This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): support string in the non-HTML5 formatter #6439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatter for non-HTML5 inputs had logic to convert a Number into a Date (Object), but nothing for Strings (like JSON dates).
wesleycho
suggested changes
Jan 31, 2017
src/datepickerPopup/popup.js
Outdated
| @@ -119,7 +119,7 @@ function($scope, $element, $attrs, $compile, $log, $parse, $window, $document, $ | |||
| return value; | |||
| } | |||
|
|
|||
| if (angular.isNumber(value)) { | |||
| if (!angular.isObject(value)) { | |||
There was a problem hiding this comment.
I think it would be better to do !angular.isDate here
|
For my use case of using a JSON date, I also needed to enhance the validator: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support string in the non-HTML5 formatter, e.g. JSON date