Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

feat(timepicker): Added support for having UTC time in the timepicker #5734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filipkis
Copy link

@filipkis filipkis commented Apr 4, 2016

Hi,

I've implemented this small feature that adds another option to timepicker called utcTime which when set will display the time in the picker based on UTC value. In other words, no matter what timezone the date is created, the times will always be the same.

This is a tiny change that should not break any of the existing code as it only takes effect when the attribute is set to true (false by default).

Hope this can make it to official build so I don't have to maintain my own :)

@deeg
Copy link
Contributor

deeg commented Apr 4, 2016

I will let the rest of the team decide if they wanted to incorporate this feature, but I know unit tests will be needed before this PR could be merged.

@icfantv
Copy link
Contributor

icfantv commented Apr 4, 2016

i'm inclined to reject this as being pretty heavy-handed and something that the user can (and probably should) do on their end.

@wesleycho
Copy link
Contributor

I'm wary about this as well - this seems like it would bloat the component for marginal gains. One should think of a timepicker as a storage of hours and minutes information - we probably should never have used a date object and should have just used a POJO instead.

@icfantv
Copy link
Contributor

icfantv commented Apr 6, 2016

@wesleycho, I'm ok with a breaking change to switch to a pojo - with an interim support for both....maybe, but that would probably suck....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants