Skip to content

fix: controller notifying during build #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyhorn merged 2 commits into from
Dec 25, 2024
Merged

fix: controller notifying during build #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bd42a9
fix: controller notifying during build
andyhorn Dec 25, 2024
2efd21d
Use named argument for notify
andyhorn Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/resizable_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class _ResizableContainerState extends State<ResizableContainer> {
void initState() {
super.initState();

controller.setChildren(widget.children);
manager.initChildren(widget.children);
}

@override
Expand Down
17 changes: 16 additions & 1 deletion lib/src/resizable_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,22 @@ class ResizableController with ChangeNotifier {
}

void setChildren(List<ResizableChild> children) {
_setChildren(children, notify: true);
}

void _initChildren(List<ResizableChild> children) {
_setChildren(children, notify: false);
}

void _setChildren(List<ResizableChild> children, {required bool notify}) {
_children = children;
_sizes = children.map((child) => child.size).toList();
_pixels = List.filled(children.length, 0);
_needsLayout = true;
notifyListeners();

if (notify) {
notifyListeners();
}
}

void _setRenderedSizes(List<double> pixels) {
Expand Down Expand Up @@ -328,6 +339,10 @@ final class ResizableControllerManager {
void setNeedsLayout() {
_controller._needsLayout = true;
}

void initChildren(List<ResizableChild> children) {
_controller._initChildren(children);
}
}

abstract class ResizableControllerTestHelper {
Expand Down
Loading