fix(player): double-buffer audio for seamless track transitions#13
Open
andronedev wants to merge 1 commit into
Open
fix(player): double-buffer audio for seamless track transitions#13andronedev wants to merge 1 commit into
andronedev wants to merge 1 commit into
Conversation
Two HTMLAudioElements alternate as the active player; the next track is preloaded on the inactive one and a transition just swaps which element drives state. The MediaSession-attached element is no longer destroyed between tracks (no kWebMediaPlayerDestroyed -> kPlay cycle), which fixes: - Android notification disappearing for ~2s between tracks - Auto-advance failing in background (Chromium Android / Vanadium / GrapheneOS) because the autoplay gesture token was invalidated by the MediaSession orphaning during src reassignment Falls back to in-place src reassignment when the next track wasn't prefetched (first play, random pick, user jump). Listeners attached to both elements with an "el !== activeAudio()" guard so the prefetch element never drives store state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two HTMLAudioElements alternate as the active player; the next track is preloaded on the inactive one and a transition just swaps which element drives state. The MediaSession-attached element is no longer destroyed between tracks (no kWebMediaPlayerDestroyed -> kPlay cycle), which fixes:
Falls back to in-place src reassignment when the next track wasn't prefetched (first play, random pick, user jump). Listeners attached to both elements with an "el !== activeAudio()" guard so the prefetch element never drives store state.