-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[FEATURE] Update Views-Hilt Project to API Level 34 with Gradle 8.4 #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrlonewolfer
wants to merge
1
commit into
android:views-hilt
Choose a base branch
from
mrlonewolfer:views-hilt
base: views-hilt
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small-dream
approved these changes
Apr 25, 2024
Deymon13
approved these changes
Oct 1, 2024
哈哈,
|
تم |
哈哈,
|
abooodabdlaa
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
نعم
ABOArb3646
approved these changes
Oct 30, 2024
jbmichaels1984
approved these changes
Apr 25, 2025
哈哈,
|
jbmichaels1984
approved these changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the Views-Hilt project to API level 34 and uses Gradle version 8.4. The changes include updates to the AndroidManifest, build.gradle files, and some Kotlin code.
Changes
AndroidManifest.xml
to addandroid:exported="true"
attribute to theTasksActivity
declaration.TasksViewModel.kt
to replaceTransformations.map
withmap
extension function.build.gradle
files to use newer versions of dependencies, including Kotlin, Navigation, Hilt, and other libraries.multiDexEnabled true
in thedefaultConfig
block of the app-levelbuild.gradle
to enable multidex support.TodoApplication.kt
to importBuildConfig
fromandroidx.multidex
package.Event.kt
to fix the method signature foronChanged
to match the interface.HiltExt.kt
to useR.style.AppTheme
instead ofR.style.FragmentScenarioEmptyFragmentActivityTheme
forthemeResId
parameter.Purpose
This PR aims to update the Views-Hilt project to support API level 34 and use the latest version of Gradle, enabling compatibility with newer Android features and libraries. It resolves build errors and ensures the project can be built and run successfully.
Notes
Without this PR, the Views-Hilt project is not able to build and run due to compatibility issues with API level 34 and Gradle 8.4. This PR resolves those issues and ensures the project can be built and run smoothly.