This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Fix building issues with rust 1.6 #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The saboteur tries this crap again! At least he found out how to fix his "fix" this time. |
|
Yup! But it doesn't build because of the rand package that's weird |
|
That's completely unrelated and due to changes in nightly rust 1.7. |
|
Oh ok so how to fix this? |
|
You should open an issue with |
|
Ok but is my fix "good"? Because I need some advice |
|
It should work - did you test it by running the binary? |
|
Yes it works |
|
Ok then, it's probably safe to merge. |
|
Ok thanks |
|
Oh, and you don't have to report it anywhere - it's a known regression in nightly just as I'd suspected. EDIT I can confirm the patched source builds (and works) correctly on |
|
oh ok i didn't notice that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix building issues with rust 1.6.