ci: windows: Merge windows images #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbyavuz
force-pushed
the
merge-windows-ci
branch
from
4bb2184 to
86e85fa
Compare
Owner
|
What are the before and combined images sizes? |
Collaborator
Author
Before: Combined: ~11 GB |
Owner
|
That's very cool. |
anarazel
reviewed
Jul 31, 2023
packer/windows.pkr.hcl
Outdated
| # packer version is 1.6.6 while generating the vm images, and it complains | ||
| # if local.only.docker is used here | ||
| only = ["docker.windows_ci_vs_2019", "docker.windows_ci_mingw64"] | ||
| only = ["docker.windows_container", "docker.windows_container"] |
Owner
There was a problem hiding this comment.
Let's drop the windows containers before we get to this bit - since all users would need to change the name of the container anyway, there's not much point in continuing to build them.
nbyavuz
force-pushed
the
merge-windows-ci
branch
2 times, most recently
from
aaf92dc to
9f172ef
Compare
Collaborator
Author
|
Note that this PR is rebased onto #87. |
nbyavuz
force-pushed
the
merge-windows-ci
branch
from
9f172ef to
54f9bd3
Compare
There's a lot of redundant data in the two images, and the image storage costs are starting to be noticable; so merge these images.
nbyavuz
force-pushed
the
merge-windows-ci
branch
from
54f9bd3 to
5908212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of redundant data in the two images, and the image storage
costs are starting to be noticable; so merge these images.
I tested and confirmed it is working. This PR needs to merged together with anarazel/postgres#84.
Closes #65