Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove css-scroll-timeline #191

Merged

Conversation

AlexWayfer
Copy link
Contributor

It has been deleted in caniuse 1.0.30001655

@dargmuesli
Copy link
Contributor

@clshortfuse may I request a short review from you on this breaking issue? ❤️

@alSergey
Copy link

Hi, is there any progress on this merge request? Now I have to write an override on the caniuse-lite library, which is very inconvenient. I would like to have a full solution to the problem.

@clshortfuse
Copy link
Collaborator

Thanks for the PR. Unfortunately modifications to the package-lock.json aren't things that should be done over PR for security reasons. So I had to pull the repo and do it manually. Then I got into a whole ordeal trying to get the codebase testing to work with node v20.

You don't actually have to remove the feature. We should just account for the discrepancy between the two. If not, we'd be having to patch every single time something gets removed from caniuse. I added a recent commit that should resolve that. I'll try to fix whatever's going on with npm v20 and push a npm update.

@dargmuesli
Copy link
Contributor

Thank you very much for your work @clshortfuse! 💚

@clshortfuse
Copy link
Collaborator

@AlexWayfer can you modify the PR to just remove the feature without the package related changes?

@AlexWayfer
Copy link
Contributor Author

@AlexWayfer can you modify the PR to just remove the feature without the package related changes?

I'm still not sure how do you catch this, but excluding package changes — not a problem, I can do this at this weekend.

@dargmuesli
Copy link
Contributor

Hmm, I think something broke with v6.0.3:

image

Seems like this .some here works differently now: 5199d86

It has been deleted in `caniuse` 1.0.30001655
@AlexWayfer AlexWayfer force-pushed the remove_css-scroll-timeline branch from 6fd06f2 to 2097197 Compare September 25, 2024 18:57
@AlexWayfer
Copy link
Contributor Author

@clshortfuse done. Is it okay now?

@Opty1712
Copy link

I have problems too, take a look here
browserslist/caniuse-lite#133

Please remove this feature and make a release

@clshortfuse clshortfuse merged commit c183f22 into anandthakker:master Oct 21, 2024
@clshortfuse
Copy link
Collaborator

Pushed v6.0.5 to npm

@AlexWayfer AlexWayfer deleted the remove_css-scroll-timeline branch October 21, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants