-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove css-scroll-timeline
#191
Remove css-scroll-timeline
#191
Conversation
@clshortfuse may I request a short review from you on this breaking issue? ❤️ |
Hi, is there any progress on this merge request? Now I have to write an override on the caniuse-lite library, which is very inconvenient. I would like to have a full solution to the problem. |
Thanks for the PR. Unfortunately modifications to the You don't actually have to remove the feature. We should just account for the discrepancy between the two. If not, we'd be having to patch every single time something gets removed from caniuse. I added a recent commit that should resolve that. I'll try to fix whatever's going on with npm v20 and push a npm update. |
Thank you very much for your work @clshortfuse! 💚 |
@AlexWayfer can you modify the PR to just remove the feature without the package related changes? |
I'm still not sure how do you catch this, but excluding package changes — not a problem, I can do this at this weekend. |
Hmm, I think something broke with v6.0.3: Seems like this |
It has been deleted in `caniuse` 1.0.30001655
6fd06f2
to
2097197
Compare
@clshortfuse done. Is it okay now? |
I have problems too, take a look here Please remove this feature and make a release |
Pushed v6.0.5 to npm |
It has been deleted in
caniuse
1.0.30001655