Fix matplotlib deprecation warning and adds some minor improvements #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rove regex performance using re.compile
amueller
reviewed
Apr 28, 2023
| else 0) | ||
| pattern = r"\w[\w']*" if self.min_word_length <= 1 else r"\w[\w']+" | ||
| regexp = self.regexp if self.regexp is not None else pattern | ||
| if self.regexp is not None: |
Owner
There was a problem hiding this comment.
Thanks for the PR!
This call to compile actually doesn't change anything, as the object is only used once, right?
Author
There was a problem hiding this comment.
Really sorry for the long delay. Yes there's no change on the workflow. The ideia is to simplify.
All the tests have passed locally, do you think it's useful to include any more?
Owner
There was a problem hiding this comment.
No worries, I'm only very sporadically on this project these days. How does this change about the re simplify, the code gets longer, right?
|
Just a friendly ping here; Matplotlib 3.9 will be out soon and this deprecation will be a hard error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/test_wordcloud.py: 46 warnings wordcloud/wordcloud.py:106: MatplotlibDeprecationWarning: The get_cmap function was deprecated in Matplotlib 3.7 and will be removed two minor releases later. Use ``matplotlib.colormaps[name]`` or ``matplotlib.colormaps.get_cmap(obj)`` instead. self.colormap = plt.cm.get_cmap(colormap)