Skip to content

Conversation

@twifkak
Copy link
Member

@twifkak twifkak commented Aug 3, 2021

Notable changes:

  • Improved EAB/HMAC flow for ACME.
  • Improved Prometheus metrics.
  • Enable hero preloading for <img> tags.
  • Update dependencies to latest versions.

/cc @SuperQ

honeybadgerdontcare and others added 26 commits May 12, 2021 08:38
…ctory URL from DigiCert. (#534)

* Fix EAB/HMAC flow.  The lego client was being reset, losing all it's challenge solvers after ResolveAccountByKey is called.

* Add instructions in the README as to how to retrieve old style ACME Directory URL
Chrome feature flag AllowSignedHTTPExchangeCertsWithoutExtension was
removed in M89. https://bugs.chromium.org/p/chromium/issues/detail?id=862003

Fortunately, the ability to test SXGs using certificates lacking the
CanSignHttpExchanges(Draft) extension is still possible thanks to an
update to the --ignore-certificate-errors-spki-list command line flag.
https://bugs.chromium.org/p/chromium/issues/detail?id=956471

Update instructions to include an example of 1) how to launch Chrome
using this flag, and 2) how to generate a certificate public hash
suitable for use by this flag.

Additional information about flag:
https://chromium.googlesource.com/chromium/src/+/refs/tags/89.0.4389.130/services/network/public/cpp/network_switches.cc#24
PiperOrigin-RevId: 375756231
PiperOrigin-RevId: 378016870
Update Prometheus client library to the latest release.

Signed-off-by: SuperQ <[email protected]>
In order to provide various runtime code profiling featuers, add the
standard Go pprof endpoint. This will allow investigations into
excessive CPU and memory use.

Signed-off-by: SuperQ <[email protected]>
This is an overhaul of the Prometheus metrics. The goal is to improve
usability by following best practices.

Use Histograms rather than summaries.
* Summaries can not be aggregated, this makes them unusable when you run
multiple instances of the service.
* Histograms provide the ability to use "heatmap" views of the data.

Drop counters that duplicate data we already have in the histogram `_count` metric.

Rename metrics to follow Prometheus naming conventions. For example,
prefixing custom metrics with the app name as a `Namespace`.

Related to #357

Signed-off-by: SuperQ <[email protected]>
Add a `-version` flag and metric to make it possible to monitor the
deployed version.

Update the build instructions to use a Makefile to simplify building for
various Go versions.

Signed-off-by: SuperQ <[email protected]>
Update to the latest go-acme/lego major version.

Signed-off-by: SuperQ <[email protected]>
Update several Go modules to current releases. Un-pin some hard-coded
overrides that don't seem to impact build/test.

Add `update-go-deps` make target to simplify updating.

Signed-off-by: SuperQ <[email protected]>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
To be compatible with the new API:
- Rename CertChainItem to AugmentedCertificate.
- Remove PEM decoding from util.ParsePrivateKey as that is now handled by
  signedexchange.ParsePrivateKey.
- Add a separate parser for an RSA private key as
  signedexchange.ParsePrivateKey no longer allows that type. Likewise, update
  tests to use ECDSA key as appropriate.
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
@twifkak twifkak requested review from antiphoton and banaag August 3, 2021 20:07
@twifkak twifkak requested a review from Gregable August 3, 2021 20:50
@twifkak twifkak removed the request for review from antiphoton August 3, 2021 20:50
@twifkak twifkak merged commit 9cd448f into releases Aug 3, 2021
@SuperQ
Copy link
Contributor

SuperQ commented Aug 3, 2021

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants