Skip to content

Image size has been changed #40291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Image size has been changed #40291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions examples/visual-tests/article-access.amp/article-access.amp.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,18 @@
background: #fa7;
}

main .hero-image-container {
max-width: 720px;
width: 100%;
margin: 0 auto;
overflow: hidden;
}
main .hero-image-container amp-img {
width: 100% !important;
height: auto !important;
display: block;
max-width: 100% !important;
}
</style>
<script async custom-element="amp-analytics" src="https://cdn.ampproject.org/v0/amp-analytics-0.1.js"></script>
<script async custom-element="amp-access" src="https://cdn.ampproject.org/v0/amp-access-0.1.js"></script>
Expand Down Expand Up @@ -198,15 +210,17 @@
</header>
<main role="main">
<article>
<figure>
<amp-img
src="img/[email protected]"
srcset="img/[email protected] 1x, img/[email protected] 2x"
layout="responsive" width="360" placeholder
alt="Curabitur convallis, urna quis pulvinar feugiat, purus diam posuere turpis, sit amet tincidunt purus justo et mi."
height="216">
</amp-img>
</figure>
<div class="hero-image-container">
<figure>
<amp-img
src="img/[email protected]"
srcset="img/[email protected] 1x, img/[email protected] 2x"
layout="responsive" width="360" placeholder
alt="Curabitur convallis, urna quis pulvinar feugiat, purus diam posuere turpis, sit amet tincidunt purus justo et mi."
height="216">
</amp-img>
</figure>
</div>

<div class="content-container">
<header>
Expand All @@ -220,7 +234,7 @@ <h1 itemprop="headline">Lorem Ipsum</h1>

<div class="author">
<amp-img src="img/sample.jpg" id="author-avatar" placeholder
height="50" width="50">
layout="responsive" width="360" height="216">
</amp-img>
<div class="byline">
<p>
Expand Down
34 changes: 33 additions & 1 deletion examples/visual-tests/article.amp/article.amp.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,20 @@

figure {
margin: 0;
text-align: center;
}

figure .full-bleed {
margin-left: auto;
margin-right: auto;
display: block;
}


figure .full-bleed amp-img {
margin-left: auto;
margin-right: auto;
display: block;
}

figcaption {
Expand Down Expand Up @@ -211,6 +225,24 @@
color: #666666;
}

.hero-img {
position: relative;
width: 90%;

}

amp-img,
.full-bleed amp-img,
#hero-img,
#floating-headline-img {
max-width: 1000px;
max-height: 500px;
width: 100%;
height: auto;
display: block;
margin-left: auto;
margin-right: auto;
}
</style>
<link href='https://fonts.googleapis.com/css?family=Georgia|Open+Sans|Roboto' rel='stylesheet' type='text/css'>
<script async custom-element="amp-ad" src="https://cdn.ampproject.org/v0/amp-ad-0.1.js"></script>
Expand Down Expand Up @@ -322,7 +354,7 @@ <h1 itemprop="headline">Lorem Ipsum</h1>

<div class="author">
<amp-img src="img/sample.jpg" id="author-avatar" placeholder
height="50" width="50">
layout="responsive" width="360" height="216">
</amp-img>
<div class="byline">
<p>
Expand Down
Loading