Skip to content

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Aug 10, 2025

Summary

Fix a variety of typographical errors and formatting inconsistencies across sample HTML fixtures, core modules, tests, and demo templates.

Tests:

  • Correct spelling in test suite and case descriptions for transformers and optimizer integration tests.

Chores:

  • Correct misspellings and extra whitespace in AMP sample HTML files (e.g., constants, initial, compensate, placeholder).
  • Fix typos in code comments, JSDoc annotations, log messages, and rename identifier CSS_LENGTH_FORTY_FOUR_PX for consistency.
  • Amend e-commerce demo templates to correct JSON comments and form field names (object spelling, message input).
  • Update linter rule message and deprecation notices to fix warning text and spelling errors.

@JamBalaya56562 JamBalaya56562 force-pushed the src-typos branch 2 times, most recently from 4f57ead to e9b388e Compare August 12, 2025 23:05
@danielrozenberg
Copy link
Member

I'd rather not change any of the files under packages/cloudflare-optimizer-scripts as these are test files based on real-world data, so fixing typos in them isn't necessary, but risks breaking existing tests. Can you revert those please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this file as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert please

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also all of the files in this directory - basically, all the .html files

@JamBalaya56562 JamBalaya56562 force-pushed the src-typos branch 8 times, most recently from e39c2ea to 84ea93f Compare August 14, 2025 23:01
@JamBalaya56562
Copy link
Contributor Author

Thank you for your review.
I have reverted the files which you mentioned.

By the way, CI errors are related to puppeteer settings.
I have raised the PR to fix it.

@danielrozenberg danielrozenberg merged commit 6bb0a8c into ampproject:main Aug 15, 2025
1 of 7 checks passed
@danielrozenberg
Copy link
Member

I have raised the PR to fix it.

I saw! It's going to be a few days before I can get to it though

@JamBalaya56562 JamBalaya56562 deleted the src-typos branch August 24, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants