Skip to content

docs: fix typos #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

docs: fix typos #1374

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17905f5
docs: fix typos
JamBalaya56562 Aug 10, 2025
92c2c6e
revert: update changelog.md
JamBalaya56562 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
* [#1140](https://github.com/ampproject/amp-toolbox/pull/1140) Enable ESM module version of AMP Runtime and Components by default ([@sebastianbenz](https://github.com/sebastianbenz))
* `page-experience`
* [#1174](https://github.com/ampproject/amp-toolbox/pull/1174) PX: enable mobile device emulation ([@sebastianbenz](https://github.com/sebastianbenz))
* [#1173](https://github.com/ampproject/amp-toolbox/pull/1173) PX:ignore invinsible elements ([@sebastianbenz](https://github.com/sebastianbenz))
* [#1173](https://github.com/ampproject/amp-toolbox/pull/1173) PX:ignore invincible elements ([@sebastianbenz](https://github.com/sebastianbenz))
Copy link
Member

@danielrozenberg danielrozenberg Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be invisible :)

Copy link
Contributor Author

@JamBalaya56562 JamBalaya56562 Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.
I accidentally modified the changelog.

I reverted the CHANGELOG.md to sync PR title at 92c2c6e.

* [#1172](https://github.com/ampproject/amp-toolbox/pull/1172) PX: escape html in suggestions ([@sebastianbenz](https://github.com/sebastianbenz))
* [#1171](https://github.com/ampproject/amp-toolbox/pull/1171) PX: detect hero images ([@sebastianbenz](https://github.com/sebastianbenz))
* [#1168](https://github.com/ampproject/amp-toolbox/pull/1168) Check for early iframes ([@patrickkettner](https://github.com/patrickkettner))
Expand Down Expand Up @@ -720,7 +720,7 @@
- `cli`, `download-runtime`
- [#663](https://github.com/ampproject/amp-toolbox/pull/663) download-runtime: Add tool to download AMP runtime ([@mdmower](https://github.com/mdmower))
- `cache-url`, `cli`
- [#666](https://github.com/ampproject/amp-toolbox/pull/666) Update CURLs hasing algorithm ([@sebastianbenz](https://github.com/sebastianbenz))
- [#666](https://github.com/ampproject/amp-toolbox/pull/666) Update CURLs hashing algorithm ([@sebastianbenz](https://github.com/sebastianbenz))
- `optimizer`
- [#636](https://github.com/ampproject/amp-toolbox/pull/636) optimizer: Output amp-geo API meta tags ([@mdmower](https://github.com/mdmower))

Expand Down Expand Up @@ -762,7 +762,7 @@
- [#649](https://github.com/ampproject/amp-toolbox/pull/649) Encode JSON values ([@sebastianbenz](https://github.com/sebastianbenz))
- [#618](https://github.com/ampproject/amp-toolbox/pull/618) Fix: auto extension import amp-access-laterpay & amp-subscriptions-google ([@sebastianbenz](https://github.com/sebastianbenz))
- `linter`
- [#626](https://github.com/ampproject/amp-toolbox/pull/626) Test explicitly for existance of value ([@dritter](https://github.com/dritter))
- [#626](https://github.com/ampproject/amp-toolbox/pull/626) Test explicitly for existence of value ([@dritter](https://github.com/dritter))

#### :house: Internal

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ npm run test:node -- packages/optimizer

### Style & Linting

This codebase adheres to the [Google Javascript Styleguide](https://google.github.io/styleguide/jsguide.html) and is enforced using ESLint. ESLint is run as part of the test suite, but you can also explicity run it via:
This codebase adheres to the [Google Javascript Styleguide](https://google.github.io/styleguide/jsguide.html) and is enforced using ESLint. ESLint is run as part of the test suite, but you can also explicitly run it via:

```
# run ESLint
Expand Down
2 changes: 1 addition & 1 deletion packages/cors/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ app.use(ampCors({

### Logging

For debugging requests, you can enable the verbose loggin mode via the `verbose` option:
For debugging requests, you can enable the verbose logging mode via the `verbose` option:

```
app.use(ampCors({
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ Enables hero image optimization. Hero images will either be auto detected or you

The maximum number of hero images that can be marked up using `data-hero` is `2`. This number can be increased using the `maxHeroImageCount` parameter.

Hero images are optimized by server-side rendering the `img` element inside the `amp-img` element. This can siginificantly improve image rendering performance and reduce the [largest contentful paint](https://web.dev/lcp/) (LCP) metric from [Core Web Vitals](https://web.dev/vitals/).
Hero images are optimized by server-side rendering the `img` element inside the `amp-img` element. This can significantly improve image rendering performance and reduce the [largest contentful paint](https://web.dev/lcp/) (LCP) metric from [Core Web Vitals](https://web.dev/vitals/).

- name: `optimizeHeroImages`
- valid options: `[true|false]`
Expand Down
Loading