Remove unused CSS #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull out styles for form elements, tables, nav, carousel, among others. Pull out a bunch of unused utility classes, e.g. for floats.
carylee
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out styles for form elements, tables, nav, carousel, among others. Pulled out a bunch of unused utility classes, e.g. for floats.
My strategy here was 1) common sense and 2) doing searches in the HTML for classes and class name prefixes found in the CSS. Two
carousel.htmlandnav.htmlincludes are both unused, so I went ahead and stripped out any CSS that only applied to elements/classes found in those files as well.I did some side-by-side comparisons in Chrome and everything looked the same, but it would be great if someone else could give this a look as well.