Amonks/shellcheck #124
Merged
Amonks/shellcheck #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amonks
force-pushed
the
amonks/shellcheck
branch
2 times, most recently
from
126e830 to
804461d
Compare
Before f48d166, tasks were kept in a map, so ingesting the same task more than once simply rewrote the map key, and was a no-op. After, tasks are kept in a composite data structure that includes a list, so adding the same task more than once caused it to be included more than once in the list.
taskfile ingestion put tasks in order, which was enough to make `run -list` appear correct, but then when run_task picked the subset for a given run to put in the sidebar, it put them out-of-order again. I've now verified that the tasks appear in the correct order in the sidebar. I ought to write a test for this, but I don't feel like it. fixes #123
amonks
force-pushed
the
amonks/shellcheck
branch
from
804461d to
9b13ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.