large batch of changes #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reserving task IDs for internal use (which means that adding any new internal task ID is a breaking change), we create a new namespace with the '@' prefix for internal tasks. BREAKING CHANGE: '@' is now a reserved character in task IDs.
closes #54 Before this change, we only used this stream for fsevents and the status at the end of a run. The status events weren't especially useful: it's weird to keep the UI open after a run is over, and we print exit status after closing the UI anyway. This change makes the stream a more purposeful: - renames it to "watch" (I considered "files", but I like that "watch" matches the word used in taskfiles) - removes the useless status events - only shows the steram if the run includes file watchers
I do not understand what caused this issue, but somehow f48d166 introduced an error where tasks would report, error: wait: no child processes I can't reproduce the error before that commit, and `run prerelease` (or `run build`) consistently produces the error after it. This change catches and ignores the error. I feel very queasy about this change.
color.Render has a crash, but since it's only exercised by a `main` package, it wasn't caught in tests. This change exercises the `main` package a bit. It would be nice to do the integration tests this way, too, but that's a project for another day. This commit is a failing test; the next commit fixes it.
Fixes a crash that only showed up in run -list
f48d166 didn't actually create a stable ordering, because load returned a map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.