feat: determine runType by root task

Previously, the appearance of any "long" task in a run would make the
whole run "long" (and therefore not exit upon completion of the root
task). That meant you couldn't have, eg, a CI test depend on a
long-running mock server.

Now, we determine the runType based on the root task only.

pkg/run/run_task.go

@@ -22,7 +22,6 @@ func RunTask(dir string, allTasks Tasks, taskID string) (*Run, error) {
 		return nil, err
 	}
 
-	runType := RunTypeShort
 	tasks := map[string]Task{}
 	byDep := map[string][]string{}
 	byTrigger := map[string][]string{}
@@ -45,10 +44,6 @@ func RunTask(dir string, allTasks Tasks, taskID string) (*Run, error) {
 			return errors.New(strings.Join(lines, "\n"))
 		}
 
-		if t.Metadata().Type == "long" {
-			runType = RunTypeLong
-		}
-
 		tasks[id] = t
 		taskStatus.set(id, TaskStatusNotStarted)
 
@@ -72,6 +67,11 @@ func RunTask(dir string, allTasks Tasks, taskID string) (*Run, error) {
 		return nil, err
 	}
 
+	runType := RunTypeShort
+	if tasks[taskID].Metadata().Type == "long" {
+		runType = RunTypeLong
+	}
+
 	run := Run{
 		mu: newMutex("run"),
 

pkg/run/testdata/snapshots/long-dependency/out.log

@@ -1,4 +1,4 @@
-long
+ok
 
   prereq  starting
           ...
@@ -8,11 +8,6 @@ long
           hello
           exit ok
 
-  prereq  ...
-          ...
-          ...
-          ...
-          canceled; stopping
+     run  done
 
-     run  run canceled
-          done
+  prereq  canceled; stopping