-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-in for MFA requirement explicitly #91
Conversation
Thank you for the PR! However, this change is redundant as MFA has long been required for gems with a high number of downloads, and I'd rather not add code that has no effect. |
Hi, thanks for your anwser I know that it is required for gems with "a high number of downloads", however I've submitted the PR the same because it will explicitly add to rubygems "NEW VERSIONS REQUIRE MFA" and "VERSION PUBLISHED WITH MFA" fields. I usually check all the libraries in our stack when there is an upgrade to confirm that it was pushed by a legit account Ref: https://rubygems.org/gems/regexp_parser This libraryRails |
I can edit the commit message because the first one is a copy & paste. For this gem, it would more appropriate to add the fact that explicitly enabling mfa will show metadata information on rubygems |
As a pupular gem, `regexp_parser` implicitly requires that all privileged operations by any of the owners require OTP. However, by explicitly setting `rubygems_mfa_required` metadata, the gem will show "NEW VERSIONS REQUIRE MFA" and "VERSION PUBLISHED WITH MFA" in the sidebar at https://github.com/ammar/regexp_parser Ref: - https://blog.rubygems.org/2022/08/15/requiring-mfa-on-popular-gems.html - https://guides.rubygems.org/mfa-requirement-opt-in/
4d588f9
to
50f6259
Compare
Rebased and reworded, now it should be better |
Yeah so this is about making the MFA fact more "machine parsable" not so much about changing the fact MFA is required. I know / run corporate tools that scan for this signal. It makes All my popular gems are also under that explicit metadata signal BTW. |
That makes sense, thanks for the explanations. I've released v2.9.2 with this change. |
As a pupular gem,
regexp_parser
implicitly requires that allprivileged operations by any of the owners require OTP.
However, by explicitly setting
rubygems_mfa_required
metadata, thegem will show "NEW VERSIONS REQUIRE MFA" and
"VERSION PUBLISHED WITH MFA" in the sidebar at
https://github.com/ammar/regexp_parser
Ref: