-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few ideas for fluentRevealNavbar.uc.js #77
Open
emvaized
wants to merge
33
commits into
aminomancer:master
Choose a base branch
from
emvaized:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d7bc621
Fix issue of script non-working for me on Firefox 115
emvaized 0cc13b7
Add option to cache nav bar buttons
emvaized 0f5df53
Add option to filter out mouse events too far from navbar
emvaized e45dba3
Added variable to store cached buttons
emvaized 130957e
Changed default color to browser navbar button hover
emvaized 293cc72
Add option to apply the effect to url bar as well
emvaized 75f9e8d
Remove unused scroll listener
emvaized ab69194
Added comment about the change
emvaized a0dec4f
Don't apply effect to focused url bar
emvaized aeceba5
Add comment and some padding to make sure effect clears out
emvaized 73c0482
Clear all effects once when cursor leaves the interactive zone
emvaized 77bf366
Changed cacheButtons default value to prevent unexpected behavior for…
emvaized 8126494
Bring back "scroll" event listener (as I figured out why it was there)
emvaized 7af0251
Move cached buttons from static to script scope
emvaized 97905a7
Remove console log and commented lines
emvaized d1091d5
Added alternative default color
emvaized 94dc10c
Better selector for url background
emvaized 2179e71
Change area selector for url bar
emvaized 4586237
Fixed comment
emvaized a2cfeb5
Fix for bookmarks
emvaized 0c82178
Changed pointer events check to use getComputedStyle(el)
emvaized af6d576
Use this._toolbarButtons for storing cached buttons
emvaized 96f3ba2
Change static padding to dynamic + cache browser element
emvaized 4cf3620
Fixed typo
emvaized aeb10b2
Removed old comment
emvaized cd09975
Changed default "filterDy" value to false
emvaized 0c96706
Code cleanup
emvaized 819fd64
Removed "!area" check
emvaized 91c0217
Removed "window." part
emvaized e2aa84f
Removed absolete comment
emvaized 3fafeff
Moved "this_someEffectsApplied" assignments to the bottom
emvaized 36a2814
Removed unused "placesToolbarItems getter"
emvaized 80ac4bb
Removed extra line on bottom
emvaized File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code below needs to be fixed, or there is a bug when you move the mouse around the top of the page on about:config or about:preferences, etc. It's because they are in the parent process so their true event targets pass all the way up to the chrome window listener (normally the event target we see would be
<browser>
).It's better if we just use MousePosTracker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't know about this bug, so my first thought was this check was added just for UX convenience. So now this should be handled by new
getComputedStyle(el).pointerEvents == "none"
check, right?