sync develop and main #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport fixes from main
We're using deprecated methods to get the IST dates, as far as I know there is no other way to get IST from chrono. Have allowed deprecated methods on the two lines where we get the date to prevent clippy from crashing in CI. Additionally, removed an unused import in `main.rs` Signed-off-by: Ivin Joel Abraham <[email protected]>
Signed-off-by: Ivin Joel Abraham <[email protected]>
… docs Usually, I'm all for inline documentation but I just realized how easily this gets outdated. Additionally, a lot of the docs should have been obvious from just reading the code and that's just clutter imo. Signed-off-by: Ivin Joel Abraham <[email protected]>
RUST_ENV was previously conflicting on our VPS since amD also had the same environment variable that specified the runtime environment. All other environment variables are properly prefixed or don't need it (such as DATABASE_URL). Signed-off-by: Ivin Joel Abraham <[email protected]>
Table aliases are more readable when using abbreviations such as `att` instead of just `a` for `attendance`. Same was done for member, substituting 'mem' instead of 'm'. Signed-off-by: Ivin Joel Abraham <[email protected]>
This query was initially added assuming it might be used, but it did not end up having any usage. Signed-off-by: Ivin Joel Abraham <[email protected]>
In both `INSERT INTO` queries, the column names were not explicitly mentioned. This can break if the schema ever changes. It can still break even with explicit mentions, in the case of required columns if we don't think about backward compatibility. Signed-off-by: Ivin Joel Abraham <[email protected]>
Previously, when a member gets their streak incremented while having a negative streak, it would simply add one to their streak, which result in still having a negative streak. This commit fixes that by setting streak to 0 if it's already negative. Signed-off-by: Ivin Joel Abraham <[email protected]>
Previously the `attendance` query had options to pass in `discord_id`, `roll_no` or `member_id`. This is unnecessary since only home uses this query and it uses `member_id`. Signed-off-by: Ivin Joel Abraham <[email protected]>
Signed-off-by: Ivin Joel Abraham <[email protected]>
Signed-off-by: Ivin Joel Abraham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.