Added a query to get the absents of month as per #27#106
Closed
he1senbrg wants to merge 1 commit intoamfoss:developfrom
Closed
Added a query to get the absents of month as per #27#106he1senbrg wants to merge 1 commit intoamfoss:developfrom
he1senbrg wants to merge 1 commit intoamfoss:developfrom
Conversation
ivinjabraham
requested changes
Jun 22, 2025
| let end_date = date | ||
| .with_day(1) | ||
| .unwrap() | ||
| .with_month(date.month() + 1) |
Member
There was a problem hiding this comment.
Won't this break when the date is in December?
|
|
||
| let end_date = date | ||
| .with_day(1) | ||
| .unwrap() |
Member
There was a problem hiding this comment.
Try not to use unwraps in the API, makes it harder to debug.
| } | ||
|
|
||
| #[derive(SimpleObject, FromRow)] | ||
| pub struct AbsentsWithMember { |
Member
There was a problem hiding this comment.
I think a more appropriate name would be MemberWithAbsence
Member
|
Completed in #143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #27