-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
115 prepare for cran #116
115 prepare for cran #116
Conversation
Did we submit to CRAN before merging this? X) |
we submitted this branch. so that in case there are any changes requested by the CRAN team we do them on this PR, and when it's finally accepted we merge. |
these were the issues raised by CRAN: the latest commits fix the first two issues:
what i can't find though are instances of the third issue they raised:
@JohnCoene are we forcing any installations anywhere? can't seem to find any. |
Maybe they scan for |
@JohnCoene you can now merge this :) |
Nice work mate! Happy to see ambiorix back on CRAN :) |
closes #115
if (interactive()) {}
instead of\dontrun {}
for function examplesseq_along(x)
instead of1:length(x)
to avoid looping whenx
has length 0. see here.we'll merge this once the pkg is accepted on CRAN.