Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 prepare for cran #116

Merged
merged 20 commits into from
Mar 15, 2025
Merged

115 prepare for cran #116

merged 20 commits into from
Mar 15, 2025

Conversation

kennedymwavu
Copy link
Contributor

closes #115

  • use if (interactive()) {} instead of \dontrun {} for function examples
  • add examples & return values to all exported functions
  • bump pkg version
  • fix: use seq_along(x) instead of 1:length(x) to avoid looping when x has length 0. see here.
  • update NEWS.md with new features, updates & bug fixes for v2.2.0
  • correct moved urls (devOpifex -> ambiorix-web)

we'll merge this once the pkg is accepted on CRAN.

@kennedymwavu kennedymwavu linked an issue Mar 10, 2025 that may be closed by this pull request
6 tasks
@kennedymwavu kennedymwavu requested a review from JohnCoene March 10, 2025 12:27
@JohnCoene
Copy link
Collaborator

Did we submit to CRAN before merging this? X)

@kennedymwavu
Copy link
Contributor Author

we submitted this branch. so that in case there are any changes requested by the CRAN team we do them on this PR, and when it's finally accepted we merge.

@kennedymwavu
Copy link
Contributor Author

these were the issues raised by CRAN:

image

the latest commits fix the first two issues:

  1. print() / cat()
  2. writing to the user's home filespace

what i can't find though are instances of the third issue they raised:

Please do not install packages in your functions, examples or vignette.
This can make the functions,examples and cran-check very slow.

@JohnCoene are we forcing any installations anywhere? can't seem to find any.

@JohnCoene
Copy link
Collaborator

Maybe they scan for install.package and found it in the docker thing?

@kennedymwavu
Copy link
Contributor Author

@JohnCoene you can now merge this :)

@JohnCoene JohnCoene merged commit ad6c3bf into master Mar 15, 2025
5 of 8 checks passed
@JohnCoene
Copy link
Collaborator

Nice work mate! Happy to see ambiorix back on CRAN :)

@kennedymwavu kennedymwavu mentioned this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepare for CRAN
2 participants