Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ch: remove as_label() #106

Merged
merged 3 commits into from
Feb 16, 2025
Merged

ch: remove as_label() #106

merged 3 commits into from
Feb 16, 2025

Conversation

kennedymwavu
Copy link
Contributor

closes #103

  • remove definition & usage of as_label()
  • update documentation of methods of the Response class which used as_label() to explicitly state that name is expected to be a string.

@kennedymwavu kennedymwavu linked an issue Feb 16, 2025 that may be closed by this pull request
fix as_label() #103
Closed
@JohnCoene
Copy link
Collaborator

Thanks!

@JohnCoene
Copy link
Collaborator

Add yourself as ctb in DESCRIPTION then I merge

@JohnCoene JohnCoene merged commit 40b84f1 into master Feb 16, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnCoene JohnCoene Awaiting requested review from JohnCoene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix as_label()
2 participants
@kennedymwavu @JohnCoene