-
Notifications
You must be signed in to change notification settings - Fork 100
Validate escape sequences when parsing #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lens0021 Thank you for your time and effort. This is a really good PR! Could you please add a compiler directive to disable this warning?
|
@lens0021 This is all good, but what about the rest of the escape sequences? You can find all the escaped characters in the Bash's repository here in Moreover, for any unrecognized escape sequences Bash copies literally (so for example Could you please add missing sequences and adjust the behavior? Since Bash doesn't complain about unrecognized escape sequences, we shouldn't either. Other commands utilize this behavior like |
|
@lens0021 now that I think about it. Do we actually need to display warning at all? Since there are so many edge cases and existing commands already abuse this Bash's behaviour of copy pasting literally the same escape sequence. What do you think? |
Reverts #732 and re-adds it in
parse_escaped_string().Test