Preserve precision when unscaling Chronos-2 and Chronos-Bolt forecasts - #532
Merged
Conversation
abdulfatir
reviewed
Sep 8, 2026
| x = x * scale + loc | ||
|
|
||
| return x.to(orig_dtype) | ||
| return x.to(orig_dtype if output_dtype is None else output_dtype) |
Contributor
There was a problem hiding this comment.
Is there ever a usecase where we actually want the inverse to be cast back to orig_dtype? I am wondering if we should just always return fp32. Simply return x.
abdulfatir
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Inverse normalization is computed in float32, but its result was cast back to the model dtype. For bfloat16 models, this discards low-order bits when the time-series level is large relative to its variation. Converting predictions to float32 later in the pipeline cannot recover that information.
Reproduction
The table shows the maximum absolute delta relative to performing both normalization and inverse normalization in float32:
Changes
Testing