Skip to content

Make optional properties return None while uninitialized. - #26

Open
megng1 wants to merge 1 commit into
amaranth-lang:mainfrom
megng1:replace-notimpl-errors
Open

megng1 wants to merge 1 commit into
amaranth-lang:mainfrom
megng1:replace-notimpl-errors

Conversation

@megng1

@megng1 megng1 commented Aug 22, 2020

Copy link
Copy Markdown
Member

The previous behaviour was to raise a NotImplementedError. It is now the
responsibility of the caller to check if the property was initialized or
not.

Affected properties:

  • wishbone.Interface.memory_map
  • csr.Interface.memory_map
  • event.Source.event_map
  • periph.PeripheralInfo.irq

The previous behaviour was to raise a NotImplementedError. It is now the
responsibility of the caller to check if the property was initialized or
not.

Affected properties:
* wishbone.Interface.memory_map
* csr.Interface.memory_map
* event.Source.event_map
* periph.PeripheralInfo.irq
@megng1

megng1 commented Aug 22, 2020

Copy link
Copy Markdown
Member Author

Related to #19 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant