Add synchronous version of Verimail.verify #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Others have also requested a synchronous approach. To provide a clean API I will probably just make it so that if no callback is provided to verify(...), the call is treated as synchronous. However, if a callback is provided, it will be asynchronous. Ie. mixed verify(string test[, function callback]). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed to plug in verimail into a validation framework that requires synchronous validation methods. To get this done I extracted the synchronous portion of verify() into verifySync() and refactored vefify() to use verifySync() internally.
As it stands they are basically the exact same method with a different interface, given that the portion of verify() that would actually need to run asynchronously is commented out.