Build Unification - WDIO Mocha, Cucumber, Jasmine #15
Conversation
|
LGTM, lets, get another review |
| import type { Options } from '@wdio/types' | ||
|
|
||
| import { BROWSERSTACK_TESTHUB_UUID } from '../constants.js' | ||
| const logDir = 'logs' |
There was a problem hiding this comment.
Please add a line after import statements
| } | ||
| if (percySnapshot && percySnapshot.percyScreenshot) { | ||
| screenshotHandler = percySnapshot.percyScreenshot | ||
| screenshotHandler = (browser: WebdriverIO.Browser | WebdriverIO.MultiRemoteBrowser | string, screenshotName: any, options?: any) => { |
There was a problem hiding this comment.
Can we give types to screenshotName and options?
There was a problem hiding this comment.
Percy screenshot method accepts arguments with method overloading. Arguments accepted are either (browser, name, options) or (name, options) where options can be in any format. Hence I've kept the parameter types to any.
There was a problem hiding this comment.
screenshotName should be string only no?
| } | ||
| if (percyAppScreenshot) { | ||
| screenshotAppHandler = percyAppScreenshot | ||
| screenshotAppHandler = (driverOrName: any, nameOrOptions?: any, options?: any) => { |
| } | ||
|
|
||
| if (this._options.testObservability) { | ||
| const shouldSetupPercy = this._options.percy || (isUndefined(this._options.percy) && this._options.app) |
There was a problem hiding this comment.
percy auto-enabled needs to be handled?
There was a problem hiding this comment.
The condition after || is for auto enabling percy for App sessions.
| if (!passed) { | ||
| this._failReasons.push((error && error.message) || 'Unknown Error') | ||
| } | ||
| await this._accessibilityHandler?.afterTest(this._suiteTitle, test) |
There was a problem hiding this comment.
So that the data being populated for saving Accessibility test results is correctly populated (ref) (specifically test uuid)
| import { BStackLogger } from '../bstackLogger.js' | ||
|
|
||
| import { shouldProcessEventForTesthub } from '../testHub/utils.js' | ||
| class Listener { |
|
|
||
| try { | ||
| const url = `${DATA_ENDPOINT}/${eventUrl}` | ||
| const url = `${ENDPOINT}/${eventUrl}` |
Proposed changes
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers