Skip to content

Fix stale PR-link status sync#126

Merged
alvarosanchez merged 2 commits into
mainfrom
codex/fix-stale-pr-link-status
May 14, 2026
Merged

Fix stale PR-link status sync#126
alvarosanchez merged 2 commits into
mainfrom
codex/fix-stale-pr-link-status

Conversation

@alvarosanchez
Copy link
Copy Markdown
Owner

@alvarosanchez alvarosanchez commented May 14, 2026

Summary

  • Prevent direct pull-request link sync from overriding Paperclip issues that are already linked to a GitHub issue.
  • Add a regression covering a stale merged direct PR link alongside an open GitHub issue with an open linked PR.
  • Document the precedence rule in the plugin spec and README.

Why

GitHub issue-linked work should be driven by the live GitHub issue snapshot and its closing pull-request references. A stale direct PR-link entity could otherwise terminalize an open GitHub issue every sync tick, producing the observed in review -> done -> in review loop.

Validation

  • pnpm typecheck
  • pnpm test
  • pnpm build

Model Used

OpenAI Codex Desktop, GPT-5-based coding agent. Exact model snapshot and context-window size were not exposed by the runtime in this session. Capabilities used: shell commands, GitHub CLI/API inspection, local TypeScript test execution, and Codex app automation setup.

Copilot AI review requested due to automatic review settings May 14, 2026 09:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Sync so stale direct pull-request links no longer override status for Paperclip issues that are already linked to GitHub issues.

Changes:

  • Filters direct PR-link sync work when the Paperclip issue is GitHub-issue-linked.
  • Adds a regression test for stale merged direct PR links alongside an open GitHub issue.
  • Documents the precedence rule in README and SPEC.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/worker.ts Adds GitHub issue-link detection and filters PR-link sync candidates.
tests/plugin.spec.ts Adds regression coverage for stale direct PR-link status sync.
SPEC.md Documents GitHub issue status precedence over direct PR links.
README.md Explains PR-only fallback behavior for direct PR links.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/worker.ts
@alvarosanchez alvarosanchez merged commit 7e4561f into main May 14, 2026
1 check passed
@alvarosanchez alvarosanchez deleted the codex/fix-stale-pr-link-status branch May 14, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants