Conversation
Remove moment.js dependency and migrate all date handling to date-fns v4. All moment.Moment types replaced with native Date. date format string changed from 'YYYY-MM-DD' (moment) to 'yyyy-MM-dd' (date-fns). Key changes: - Remove moment from package.json and angular.json - Add date-fns as dependency - Update core model files (common, utility, financemodel, eventmodel, librarymodel, homedef, blogmodel, uicommon) - Update all services (finance-storage, finance-odata, event-storage, uistatus) - Update all finance/event/library/report components (~80 files) - Update all spec test files - Update README.md and credits page Build verified: ng build passes with zero errors. No moment references remain anywhere in the codebase. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…document creation tests buildFinOrders() created fake Orders without ValidFrom/ValidTo (commented out), causing Document.onVerify() to return false with InvalidActivity error. This prevented createAssetValChgDocument from being called, making 2 tests fail.
… parse errors After the moment.js -> date-fns refactor, several tests flush mock data with Date objects but the service map functions expect string dates (calling parse(string, ...)). This caused 4 unhandled 'dateString.match' errors that made CI fail with exit code 1 even though all tests passed. - event-storage.service.spec.ts: Use plain objects with startTimePoint/ endTimePoint string dates instead of EventHabitDetail instances - finance-odata.service.spec.ts: Use string date formats for TranDate, StartDate, EndDate in mock API responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace deprecated moment.js with date-fns v4 across the entire project. All date handling now uses native Date types with date-fns functions.
Changes
Files changed: 88
Verification
🤖 Generated with Claude Code