Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for latest deps for woodwork 0.28.0 #2644

Merged
merged 25 commits into from
Feb 8, 2024
Merged

Fix for latest deps for woodwork 0.28.0 #2644

merged 25 commits into from
Feb 8, 2024

Conversation

tamargrey
Copy link
Contributor

@tamargrey tamargrey commented Feb 6, 2024 •
edited
Loading

Closes #2650

Updates to work with latest deps

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3681bbb) 99.47% compared to head (58aaaae) 99.47%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2644   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files         404      404           
  Lines       24204    24204           
=======================================
  Hits        24077    24077           
  Misses        127      127

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tamargrey tamargrey changed the title Fix for latest deps Fix for latest deps for woodwork 0.28.0 Feb 8, 2024
@tamargrey tamargrey marked this pull request as ready for review February 8, 2024 19:34
thehomebrewnerd
thehomebrewnerd approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks fine, but this doesn't close the issue referenced in the PR description. I think we should update that.

@thehomebrewnerd
Copy link
Contributor

thehomebrewnerd commented Feb 8, 2024 •
edited
Loading

I think this all looks fine, but this doesn't close the issue referenced in the PR description. I think we should update that.

Ha - nvm. Either I looked at this wrong, or you changed it!

@tamargrey
Copy link
Contributor Author

I think this all looks fine, but this doesn't close the issue referenced in the PR description. I think we should update that.

@thehomebrewnerd I changed the tagged issue recently, are you talking about the pyarrow ticket (the old one) or the woodwork 0.28.0 ticket?

@tamargrey tamargrey merged commit 3ff4732 into main Feb 8, 2024
54 checks passed
@tamargrey tamargrey deleted the fix-for-latest-deps branch February 8, 2024 19:47
@tamargrey tamargrey mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

@gsheni gsheni Awaiting requested review from gsheni

Assignees

@tamargrey tamargrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update featuretools deps to work with woodwork 0.28.0
2 participants
@tamargrey @thehomebrewnerd