-
-
Notifications
You must be signed in to change notification settings - Fork 17
Fix version constraints failures. #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
The only failure remaining here now, seems to be because of Scrutinizer. But, I don't think that's our fault, because Zest isn't even mentioned anywhere at all in the stack trace:
I guess, somebody made a typo somewhere in PHP_CodeSniffer, maybe..? "ಠ_ಠ (Eh.. Oh well.. At least, we've done everything that we can, I think). |
yeah agreed |
#324 and #325 currently suffer from tests failures, which seem to originate due to the PHP version constraints specified by
composer.json
. This PR should, hopefully, fix those failures (when, of course, they're eventually ready to be merged later).(Changes to
composer.lock
are a result ofphp composer.phar update
performed after updatingcomposer.json
).