Google Tag Manager layout addition #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lfdebrux, We're really keen to use GTM on our docs-as-code sites. This PR seems to do just that (thanks @grahampaulcook 🙏 ). I think the only conflict with the latest, greatest code is a single line in version.rb. If we could get this resolved would you consider this for inclusion? Many thanks, Edd |
eddgrant
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
Aug 4, 2022
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
eddgrant
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
Feb 8, 2023
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
eddgrant
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
May 23, 2023
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
eddgrant
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
Jun 7, 2023
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
eddgrant
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
Mar 6, 2024
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
eddgrant
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
May 22, 2024
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime.
eddgrant
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
Jun 21, 2024
This is a cherry-pick of 63b2a30 from grahampaulcook/tech-docs-gem which introduces support for Google Tag Manager. A pull request has been raised to include this change: alphagov#187 however GDS have not yet picked it up, so we're pulling it in here for use at HMRC in the meantime. (cherry picked from commit 671dd75)
|
Good stuff but let's do this in v4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Google Tag Manager support into technical documentation services by adding a new configuration option in the
config/tech-docs.ymlfile.gtm_id: GTM-xxxxxThe documentation changes are within alphagov/tdt-documentation#126