Updated student finance rates for 2025-2026 academic year #7030
+148
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoni-devlin
force-pushed
the
Update-student-finance-rates-for-academic-year-2025-2026
branch
from
2b15ede to
3dad2a9
Compare
antoni-devlin
force-pushed
the
Update-student-finance-rates-for-academic-year-2025-2026
branch
from
3dad2a9 to
c4f6dda
Compare
mtaylorgds
reviewed
Jan 9, 2025
…ead of 2023/24 and 2025/26
syed-ali-tw
reviewed
Jan 17, 2025
syed-ali-tw
reviewed
Jan 17, 2025
Now that the 2023-2024 rates have been removed, the tests have been updated to use the 2024-2025 rates. In fixing tests I found a bunch that were using out of date figures. I have updated these to reference the constant values in the calculator class, rather than those values being copy/pasta'd into the tests, which is prone to error. I also removed some tests that I don't think are necessary, since they were testing that a high-income household with no dependants is not eligible for grants, when there is already a test that a low-income household with no dependants is not eligible. Some test names also made no sense to me, so I've updated the names to be more meaningful. For the tests that check the maximum amount gets reduced by £1 per every £X of income above £25k, I manually regenerated the numbers myself.
mtaylorgds
force-pushed
the
Update-student-finance-rates-for-academic-year-2025-2026
branch
from
809742c to
6229344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go-live is 3rd Feb 2025; await confirmation from SLC before merging.