Support multiple content types in details fields #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
support-govspeak-graphql
branch
2 times, most recently
from
4cde8c1 to
81db2c2
Compare
brucebolt
changed the title
brucebolt
force-pushed
the
support-govspeak-graphql
branch
4 times, most recently
from
16d377f to
5302262
Compare
brucebolt
force-pushed
the
flatten-graphql-edition
branch
from
213b539 to
e3b484b
Compare
brucebolt
force-pushed
the
support-govspeak-graphql
branch
from
5302262 to
82b93bd
Compare
This has been copied from Content Store [1] as it will be required to select the HTML content from mixed content type fields in GraphQL responses (e.g. where a document's `body` contains both govspeak and HTML representations). 1: https://github.com/alphagov/content-store/blob/5d3654322f94d21e69570b8364372387d117808b/app/presenters/content_type_resolver.rb#L1
According to ADR-004, it is possible to represent content in an array format containing multiple types. This can include already parsed govspeak in HTML format or only govspeak. In the latter case, Publishing API parses this and converts to HTML before sending the content to Content Store. This replicates that behaviour for GraphQL responses, expanding this to all fields within `details`, not just the body (e.g. the `more_information` and `need_to_know` fields, which use the Content Schema defition `body_html_and_govspeak`).. It also has the side effect of supporting embedded content and full change history in GraphQL responses.
brucebolt
force-pushed
the
support-govspeak-graphql
branch
from
82b93bd to
95045d5
Compare
mike3985
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to ADR-004, it is possible to represent content in an array format containing multiple types. This can include already parsed govspeak in HTML format or only govspeak. In the latter case, Publishing API parses this and converts to HTML before sending the content to Content Store.
This replicates that behaviour for GraphQL responses, expanding this to all fields within
details, not just the body.As we are now using the
DetailsPresenter, it also has the side effect of supporting embedded content and full change history in GraphQL responses.Trello card