Fix link checker reporting #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We often see sucessful log output from `tap-spot` followed by a non-zero error code so we’ve swapped it for `tap-mocha-reporter` like we did on GOV.UK Design System I’ve also added the `--canonicalroot` flag to check more internal assets that would have previously been skipped as external Note: We still have a broken share image * alphagov/tech-docs-gem#194
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@colinrotherham any objections to this being cherry-picked across to main? There were no conflicts so hoping the v5 branch will still merge cleanly. |
|
Nah all good, we can keep rebasing the v5 release branches The failing checks will still happen but less frequently Think it's this issue: |
colinrotherham
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks 3e3adb6 from #335 into the main branch to unblock merging PRs to main because of link checks failing (Example)
We often see sucessful log output from
tap-spotfollowed by a non-zero error code so we’ve swapped it fortap-mocha-reporterlike we did on GOV.UK Design SystemI’ve also added the
--canonicalrootflag to check more internal assets that would have previously been skipped as externalNote: We still have a broken share image