Skip to content

Commit

Permalink
Fix link checker reporting
Browse files Browse the repository at this point in the history
We often see sucessful log output from `tap-spot` followed by a non-zero error code so we’ve swapped it for `tap-mocha-reporter` like we did on GOV.UK Design System

I’ve also added the `--canonicalroot` flag to check more internal assets that would have previously been skipped as external

Note: We still have a broken share image

* alphagov/tech-docs-gem#194
  • Loading branch information
colinrotherham committed Jul 31, 2023
1 parent 320f759 commit 3e3adb6
Show file tree
Hide file tree
Showing 2 changed files with 102 additions and 45 deletions.
143 changes: 100 additions & 43 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"postinstall": "npm run build:sassdoc",
"build:sassdoc": "sassdoc --parse node_modules/govuk-frontend/dist/govuk/ > data/sassdoc.json",
"lint": "standard",
"check-links": "hyperlink -ri deploy/public/index.html --skip 'property=\"og:url\"' | tap-spot"
"check-links": "hyperlink --canonicalroot https://frontend.design-system.service.gov.uk --internal --recursive deploy/public/index.html --skip 'property=\"og:image\"' | tap-mocha-reporter min"
},
"devDependencies": {
"govuk-frontend": "github:alphagov/govuk-frontend#0f5c7975f",
"hyperlink": "^5.0.4",
"sassdoc": "^2.7.4",
"standard": "^17.1.0",
"tap-spot": "^1.1.2"
"tap-mocha-reporter": "^5.0.3"
}
}

0 comments on commit 3e3adb6

Please sign in to comment.