Add guidance for accessibility of details component#3904
Open
CharlotteDowns wants to merge 4 commits intomainfrom
Open
Add guidance for accessibility of details component#3904CharlotteDowns wants to merge 4 commits intomainfrom
CharlotteDowns wants to merge 4 commits intomainfrom
Conversation
Add more reference to the accessibility issues for Dragon users.
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
owenatgov
reviewed
Jul 29, 2024
Contributor
owenatgov
left a comment
owenatgov
left a comment
There was a problem hiding this comment.
A very minor preferential point on link text, plus a full stop. I'm not gonna kick off about the preference tbh. This looks all good otherwise.
src/components/details/index.md
Outdated
| There is [evidence that some users avoid clicking the link to show more details](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-629122091), as they think it will take them away from the page. | ||
|
|
||
| There are [concerns that some users of voice assist software will not be able to interact with the component](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-628082040). Some software might require the user to specifically refer to the link to show more details as a button in order to interact with it. | ||
| It is known that [some users of voice assist software will not be able to interact with the component](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-628082040). Some software might require the user to specifically refer to the link to show more details as a button in order to interact with it. |
Contributor
There was a problem hiding this comment.
Not anything you changed, but I find the second sentence confusing. I've read it 3 times now and can't work out what it's trying to tell me.
Contributor
Author
There was a problem hiding this comment.
@calvin-lau-sig7 are you able to help me with making this a bit clearer?
Co-authored-by: Owen Jones <64783893+owenatgov@users.noreply.github.com> Co-authored-by: Ed Horsford <mail@edwardhorsford.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add more reference to the accessibility issues for Dragon users.
Why
After visiting the Digital Accessibility Centre (DAC) and meeting a user of Dragon in and out of work, I was made aware of the difficulty they experience when using details components on pages.
I also witnessed how the language we used in our details guidance to refer to the issue made them feel untrusted.
This change is likely something we can do alongside improving the component.