Spike: support for tables - #158
Draft
lauraghiorghisor-tw wants to merge 10 commits into
Draft
Conversation
lauraghiorghisor-tw
force-pushed
the
support-for-tables-spike
branch
from
September 9, 2024 10:40
1489669 to
efd9b15
Compare
minhngocd
force-pushed
the
support-for-tables-spike
branch
from
September 9, 2024 11:11
efd9b15 to
49edb00
Compare
lauraghiorghisor-tw
force-pushed
the
support-for-tables-spike
branch
from
September 9, 2024 11:46
49edb00 to
3bf6f98
Compare
lauraghiorghisor-tw
force-pushed
the
support-for-tables-spike
branch
from
September 9, 2024 13:40
3bf6f98 to
f5b664c
Compare
minhngocd
force-pushed
the
support-for-tables-spike
branch
2 times, most recently
from
September 10, 2024 20:32
be491fa to
02aa0c5
Compare
lauraghiorghisor-tw
force-pushed
the
support-for-tables-spike
branch
from
September 11, 2024 16:04
103f46d to
5e7ca63
Compare
We hoped it would help with serialization. To remove if not proving useful.
lauraghiorghisor-tw
force-pushed
the
support-for-tables-spike
branch
2 times, most recently
from
September 11, 2024 17:11
ce4e5cb to
0019769
Compare
Basic table rendering in Markdown with header rows and columns
things that don't work yet
- toggling of header row and column at the same time that results in some cells not having the header state
- toggling individual cells - the header status is based off of entire rows
- does not support header row in the middle of the table or columns in the middle
To prove html parsing works. Included table header column and rows.
minhngocd
force-pushed
the
support-for-tables-spike
branch
from
September 12, 2024 11:37
0019769 to
fa3b357
Compare
Have a decently workable demo
So I can play around with trying to escape characters when writing to cell. Unfortunately didn't manage to achieve escaping | characters
|
I think that this approach looks good and fits in well with what we've already developed. There is definitely a lot to explore with the serialisation and wether the table container should manage all of the serialisation or pass it down to rows and cells but that always something that can be refactored with some snapshot tests. I'd be pro cleaning the PR up and adding a second spike that contains just the attempted to support cell alignment - it will be interesting to explore if this should be a property on a cell (since we don't have columns) or some sort of map on the parent table to make serialisation easier. Well done 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.