Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/accessible-autocomplete.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/accessible-autocomplete.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.preact.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.preact.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.react.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.react.min.js.map

Large diffs are not rendered by default.

12 changes: 11 additions & 1 deletion src/autocomplete.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export default class Autocomplete extends Component {
displayMenu: 'inline',
minLength: 0,
name: 'input-autocomplete',
form: '',
placeholder: '',
onConfirm: () => {},
confirmOnBlur: true,
Expand Down Expand Up @@ -405,6 +406,12 @@ export default class Autocomplete extends Component {
}
}

setFormAttribute (element) {
if (element && this.props.form) {
element.setAttribute('form', this.props.form)
}
}

render () {
const {
cssNamespace,
Expand Down Expand Up @@ -557,7 +564,10 @@ export default class Autocomplete extends Component {
onFocus={this.handleInputFocus}
name={name}
placeholder={placeholder}
ref={(inputElement) => { this.elementReferences[-1] = inputElement }}
ref={(inputElement) => {
this.elementReferences[-1] = inputElement
this.setFormAttribute(inputElement)
}}
type='text'
role='combobox'
required={required}
Expand Down
20 changes: 20 additions & 0 deletions test/functional/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,26 @@ describe('Autocomplete', () => {
expect(inputElement.getAttribute('aria-describedby')).to.equal('autocomplete-default__assistiveHint')
})

describe('renders with an form attribute', () => {
it('is not present', () => {
render(<Autocomplete />, scratch)

const wrapperElement = scratch.getElementsByClassName('autocomplete__wrapper')[0]
const inputElement = wrapperElement.getElementsByTagName('input')[0]

expect(inputElement.getAttribute('form')).to.equal(null)
})

it('is not present', () => {
render(<Autocomplete form={'myForm'} />, scratch)

const wrapperElement = scratch.getElementsByClassName('autocomplete__wrapper')[0]
const inputElement = wrapperElement.getElementsByTagName('input')[0]

expect(inputElement.getAttribute('form')).to.equal('myForm')
})
})

describe('renders with an aria-autocomplete attribute', () => {
it('of value "list", when autoselect is not enabled', () => {
render(<Autocomplete required />, scratch)
Expand Down
23 changes: 23 additions & 0 deletions test/functional/wrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -336,4 +336,27 @@ describe('Wrapper', () => {
}, 250)
}, 250)
})

it('does not add a form attribute by default', () => {
const select = injectSelectToEnhanceIntoDOM(scratch)

accessibleAutocomplete.enhanceSelectElement({
selectElement: select
})

const autocompleteInput = scratch.querySelector('.autocomplete__input')
expect(autocompleteInput.getAttribute('form')).to.equal(null)
})

it('can define a custom form for the autocomplete element', () => {
const select = injectSelectToEnhanceIntoDOM(scratch)

accessibleAutocomplete.enhanceSelectElement({
form: 'myForm',
selectElement: select
})

const autocompleteInput = scratch.querySelector('.autocomplete__input')
expect(autocompleteInput.getAttribute('form')).to.equal('myForm')
})
})