Fix compilation error with multiple accelerators #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
requested changes
Feb 6, 2025
include/mallocMC/mallocMC_utils.hpp
Outdated
| @@ -164,7 +164,7 @@ namespace mallocMC | |||
|
|
|||
| #ifdef ALPAKA_ACC_GPU_HIP_ENABLED | |||
| template<typename TDim, typename TIdx> | |||
| ALPAKA_FN_ACC inline auto lanemask_lt(alpaka::AccGpuHipRt<TDim, TIdx> const& /*acc*/) | |||
| ALPAKA_FN_ACC inline uint32_t lanemask_lt(alpaka::AccGpuHipRt<TDim, TIdx> const& /*acc*/) | |||
There was a problem hiding this comment.
ALPAKA_FN_ACC should maybe changed to __device__ too.
There was a problem hiding this comment.
BUG lanemask_lt() return type must be auto because for AMD HIP the return type is 64bit and for CUDA it is a 32bit type.
chillenzer
force-pushed
the
fix-cuda-only-mode-necessity
branch
from
a83cd69 to
9705fa1
Compare
psychocoderHPC
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inline assembly instructions for CUDA are
__device__-only.ALPAKA_FN_ACCresolves to__host__ __device__unless we are in CUDA-only mode, so this leads to compilation failures. Fixing this by applying__device__by hand in those cases.